-
Notifications
You must be signed in to change notification settings - Fork 571
[CoreMidi] Add missing CoreMIDI bindings and MidiEventList support. #24738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rolfbjarne
wants to merge
4
commits into
main
Choose a base branch
from
dev/rolf/coremidi-copilot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
46761f4
[CoreMidi] Add missing CoreMIDI bindings and MidiEventList support.
rolfbjarne 5247eb1
[CoreMidi] Add MIDIEventListForEachEvent binding and MidiUniversalMes…
rolfbjarne 01b1410
[CoreMidi] Make MidiUniversalMessage blittable (no explicit layout).
rolfbjarne a8f368c
[CoreMidi] Address PR review comments
rolfbjarne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| #nullable enable | ||
|
|
||
| namespace CoreFoundation { | ||
| // This struct is only used for P/Invokes. | ||
| struct CFUuidBytes { | ||
| #pragma warning disable CS0649 // Field '...' is never assigned to, and will always have its default value 0 | ||
| public byte Byte0; | ||
| public byte Byte1; | ||
| public byte Byte2; | ||
| public byte Byte3; | ||
| public byte Byte4; | ||
| public byte Byte5; | ||
| public byte Byte6; | ||
| public byte Byte7; | ||
| public byte Byte8; | ||
| public byte Byte9; | ||
| public byte Byte10; | ||
| public byte Byte11; | ||
| public byte Byte12; | ||
| public byte Byte13; | ||
| public byte Byte14; | ||
| public byte Byte15; | ||
| #pragma warning restore CS0649 | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 💡 Patterns — This new file is missing the repo's MIT license header and
#nullable enable. New files should start with:Rule: New-file conventions