Skip to content

Add regression test: #10043, backtick should not report unexpected keyword#19476

Open
T-Gro wants to merge 1 commit intomainfrom
regression-test/issue10043
Open

Add regression test: #10043, backtick should not report unexpected keyword#19476
T-Gro wants to merge 1 commit intomainfrom
regression-test/issue10043

Conversation

@T-Gro
Copy link
Copy Markdown
Member

@T-Gro T-Gro commented Mar 24, 2026

Adds a regression test for #10043

Verifies that let i:float1 = 3.0` produces FS3563 ("This is not a valid identifier") instead of the previous confusing "Unexpected reserved keyword" message.

Fixes #10043

@T-Gro T-Gro requested a review from a team as a code owner March 24, 2026 10:42
@T-Gro T-Gro added NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes AI-Issue-Regression-PR PR adding regression test for a closed issue labels Mar 24, 2026
@T-Gro T-Gro requested a review from abonie March 24, 2026 10:42
@T-Gro T-Gro enabled auto-merge (squash) March 24, 2026 10:42
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@auduchinok
Copy link
Copy Markdown
Member

The backticks cases were added in the previous PRs. It's more interesting to see if there are any @ or ! cases.

@T-Gro T-Gro force-pushed the regression-test/issue10043 branch from ea3d696 to f498636 Compare March 24, 2026 13:10
Tests that invalid characters in type annotation positions produce clear
error messages instead of confusing 'Unexpected reserved keyword':
- backtick: FS3563 'This is not a valid identifier'
- @: FS0615 'Unexpected infix operator in type expression'

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro T-Gro force-pushed the regression-test/issue10043 branch from f498636 to e7b6ee5 Compare March 24, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Issue-Regression-PR PR adding regression test for a closed issue NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

Unexpected keyword error when there's no keyword

2 participants