[ajcvickers]

Fixes #39573

Problem

Reverse engineering a SQLite database with an index on an expression, for example CREATE INDEX IX ON T (lower(Name)), threw InvalidOperationException: The data is NULL at ordinal 0. pragma_index_xinfo returns a NULL name (with cid = -2) for a key that is an expression, and SqliteDatabaseModelFactory.GetIndexes called GetString(0) on it.

Fix

GetIndexes now skips any index that has an expression key, including indexes that mix columns and expressions, and logs a warning. Indexes on expressions can't be represented in the model (#28360). The rest of the table, including its other indexes, is scaffolded as usual.

The warning is a new scaffolding event, SqliteEventId.ExpressionIndexSkippedWarning, registered the same way as the existing FormatWarning and OutOfRangeWarning events (event id, logging definition, resource string, logger extension and API baseline entry):

Skipping index '{indexName}' on table '{tableName}', since it is defined on an expression and indexes on expressions are not supported.

No other code path needs the change: NULL names only occur for expression keys, and SQLite does not allow expressions in UNIQUE or PRIMARY KEY constraints, so the unique-constraint and primary-key readers can't hit this.

Tests

New SqliteDatabaseModelFactoryTest tests cover an expression index next to a regular index, an expression index between two regular indexes (so skipping can't stop processing the table), a mixed column-and-expression index, tables with only expression indexes (including a unique one and an unusual name, one warning each), and an expression index alongside a unique constraint.

🤖 Generated with Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[github-actions]

API review baseline changes for src/EFCore.Sqlite.Core/EFCore.Sqlite.Core.baseline.json

Show diff

The diff below was generated by ApiChief between the base and the PR.

  static class Microsoft.EntityFrameworkCore.Diagnostics.SqliteEventId
+ static readonly Microsoft.Extensions.Logging.EventId ExpressionIndexSkippedWarning