fix(markdown): escape referenced figures' filepaths and ensure cross-platform path handling (Windows / POSIX) - #698
Open
the-zucc wants to merge 5 commits into
Open
fix(markdown): escape referenced figures' filepaths and ensure cross-platform path handling (Windows / POSIX)#698the-zucc wants to merge 5 commits into
the-zucc wants to merge 5 commits into
Conversation
Contributor
|
✅ DCO Check Passed Thanks @the-zucc, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🔴 1 of 2 protections blocking · waiting on 👀 reviews
🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
I, Laurier Lavoie-Giasson <laurier@laurier.dev>, hereby add my Signed-off-by to this commit: 513a8d5 Signed-off-by: Laurier Lavoie-Giasson <laurier@laurier.dev>
the-zucc
changed the title
added 2 commits
July 30, 2026 00:27
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
the-zucc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#182 caused a regression in which the behavior introduced in #122 was removed.
I'm therefore proposing that we re-add the change, slightly modified for both POSIX and Windows path support.
One edge-case identified is the obvious case where the destination path is a filename containing a backslash. I've mentioned the limitation in the docstring.