Update Docker workflow: checkout v7 and conditional DockerHub login - #4
Merged
Conversation
Upgrades to the latest major version which migrates to ESM and improves credential security. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0182Hve6vksjfwCUTPGJGQgh
The if: inputs.push guard is self-explanatory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0182Hve6vksjfwCUTPGJGQgh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the Docker CI/CD workflow to use a newer version of the checkout action and made the DockerHub login step conditional based on the
pushinput parameter.Key Changes
actions/checkoutfrom v6 to v7if: inputs.push, ensuring credentials are only used when actually pushing imagesImplementation Details
The DockerHub login step will now only execute when the workflow is triggered with
push: true, improving security by avoiding unnecessary credential exposure and reducing workflow execution time for non-push scenarios (such as pull request validation or dry-run builds).https://claude.ai/code/session_0182Hve6vksjfwCUTPGJGQgh