pkg/compose: fix TestRunHook_ConsoleSize on macOS#13686
Merged
glours merged 1 commit intodocker:mainfrom Mar 30, 2026
Merged
Conversation
thaJeztah
force-pushed
the
fix_TestRunHook_ConsoleSize
branch
from
57a1592 to
357ab2c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the pkg/compose hook console-size unit test to avoid containerd/console PTY usage (which can panic on macOS) by switching the test PTY implementation.
Changes:
- Replace
github.com/containerd/console.NewPty()usage withgithub.com/creack/pty.Open()inTestRunHook_ConsoleSize. - Switch cleanup from
defertot.Cleanupfor PTY file handles. - Add a (currently empty)
TestConsoletest stub.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
containerd/console is broken on macOS, and panics; use creack/pty instead for this test. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_TestRunHook_ConsoleSize
branch
from
357ab2c to
feb2dab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
Thx! We should look if we can fix containerd/console, but I ran tests on my machine, and thought I broke something, then found it was already like this 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
containerd/console is broken on macOS, and panics; use creack/pty instead for this test.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did