Repository navigation
Conversation
Pass custom policy functions to builtins() so that the complete builtin list can be constructed with a single allocation. This avoids growing the builtin slice when adding custom functions. Updates 8b1d06a Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the capability-construction optimization.
No open issues 🎉
What changed in this PR
Optimizes policy capability construction following the migration to OPA’s WithCapabilities, preallocating space for both default and custom builtins to avoid slice growth.
Changes:
- Passes custom policy functions directly to
builtins. - Allocates the combined builtin slice with sufficient capacity before appending entries.
| File | Description |
|---|---|
policy/validate.go |
Delegates custom builtin inclusion to builtins(p.funcs). |
policy/builtins.go |
Preallocates capacity for default and custom builtins and assembles the combined list. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass custom policy functions to builtins() so that the complete builtin list can be constructed with a single allocation.
This avoids growing the builtin slice when adding custom functions.
Updates 8b1d06a