Repository navigation
Reach 100% line and branch coverage - #27
Merged
Merged
Conversation
Cover the event directive, debug logging, duplicate descriptions, rebuilds, invalid config and the external link edge cases, including link testing with a mocked requests.get. Turn on branch coverage and fail the run below 100%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests to bring line and branch coverage from 91% to 100%. Branch coverage is now on, and
fail_under = 100fails the run if coverage drops.Indexer fix. Indexers rendered as
this[, int i].append_indexer_parameterstestedpnodes.children, which always includes the opening[. No test checked indexer signature text before this PR.split_sig. A comma after an unbalanced closing bracket, as in
a>, b, was silently dropped. It now splits the list. This also removes a branch that only malformed input reached.Tests.
test_render.pycovers the event directive, debug logging, duplicate descriptions, incremental rebuilds and invalid config. The newtest_extrefs.pycovers the external link edge cases, including link testing with a fakedrequests.get.