Support Ruby 4 - #75
Merged
Merged
Conversation
Ruby 4 chills string literals in files that have no magic comment: a literal is still mutable, but mutating one warns that it will be frozen in the future. The gem's one such site is the copy_to_string result buffer, so the suite passes on Ruby 4 today and the warning only surfaces under -W:deprecated. Opt lib/postgres-copy/acts_as_copy_target.rb into frozen string literals ahead of that change, and seed the result buffer with +'' so it stays mutable. Refresh the development bundle for Ruby 4, allow a compatible Rake release, and exercise Ruby 4 in CI. Use +'' rather than String.new because String.new with no arguments returns an ASCII-8BIT string, which would flip copy_to_string's result encoding for exports whose every byte is ASCII. +'' keeps the UTF-8 the method returned before.
Owner
|
Thanks for the pull request @mtam2 , sorry the merge took a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 4 chills string literals in files that have no magic comment: a
literal is still mutable, but mutating one warns that it will be frozen
in the future. The gem's one such site is the copy_to_string result
buffer, so the suite passes on Ruby 4 today and the warning only
surfaces under -W:deprecated.
Opt lib/postgres-copy/acts_as_copy_target.rb into frozen string literals
ahead of that change, and seed the result buffer with +'' so it stays
mutable. Refresh the development bundle for Ruby 4, allow a compatible
Rake release, and exercise Ruby 4 in CI.
Use +'' rather than String.new because String.new with no arguments
returns an ASCII-8BIT string, which would flip copy_to_string's result
encoding for exports whose every byte is ASCII. +'' keeps the UTF-8 the
method returned before.