Skip to content

fix(imagegen): stop TestKnownModels from requiring a model on its shutdown day - #1876

Merged
diillson merged 1 commit into
mainfrom
fix/imagegen-catalog-test-retired-model
Oct 23, 2026
Merged

diillson merged 1 commit into
mainfrom
fix/imagegen-catalog-test-retired-model

Conversation

@diillson

Copy link
Copy Markdown
Owner

What

TestKnownModels asked the image catalog for gpt-image-1. The catalog drops a model from KnownModels() on its shutdown date, and gpt-image-1 retires on 2026-10-23, so from today the test fails on main and takes every open pull request's CI down with it (Lint, Test and Generate Coverage, Floor 2 · Coverage ratchet, Quality Gate).

The catalog is right to drop it. The test now asks for the active default gpt-image-2.5-flare, and says why in a comment.

Checked

  • Reproduced on a clean origin/main checkout; fails there, passes with this change.
  • The other tests that name retiring models pin their own dates, and no other test depends on a model that retires before 2027 in KnownModels().
  • go test ./llm/..., ./cli/... and ./pkg/... pass; golangci-lint v2: 0 issues.

…tdown day

The catalog drops a model from the list on its shutdown date, and the test
asked for gpt-image-1, which retires on 2026-10-23. From that day the test,
and every pull request's CI with it, failed on main. It now asks for the
active gpt-image-2.5-flare.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Gate

Result: ✅ all floors passed

Floor Status Result Δ vs main Budget
1 · Build & Static ✅ go build / vet / fmt / lint — —
2 · Coverage ✅ 69.6% (bootstrap) 0 ≥ baseline
3 · Patch coverage ✅ 100% (req ≥ 60%) — ≥ 60%
4 · AI smells ✅ diff scanned — —
5 · Scope budget ✅ 1 files / 5 LOC (code 5 + tooling 0) — warn 800·25
6 · E2E ✅ go test -race ./e2e/... — ≤ 15min
7 · Commit lint ✅ conventional commits — —
8 · Cyclo (new code) ✅ 0 file(s) under threshold — ≤ 30
9 · Secrets scan ✅ gitleaks — —
10 · i18n parity ✅ missing 0, unknown 0 — —
11 · CRD drift ✅ drifted: 0 — —
12 · License headers ✅ 0 missing — —
13 · API breaking ✅ 0 incompatible — —
14 · Binary size ✅ chatcli 100.4MB · operator 55.4MB — 100MB each
15 · Provider parity ✅ 14 providers · 0 violations — —

Config: .github/quality-gate.yml. Workflow: .github/workflows/quality-gate.yml.

@diillson
diillson merged commit 0bcad4c into main Oct 23, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant