Repository navigation
fix(imagegen): stop TestKnownModels from requiring a model on its shutdown day - #1876
Merged
Merged
Conversation
…tdown day The catalog drops a model from the list on its shutdown date, and the test asked for gpt-image-1, which retires on 2026-10-23. From that day the test, and every pull request's CI with it, failed on main. It now asks for the active gpt-image-2.5-flare.
Contributor
Quality GateResult: ✅ all floors passed
Config: .github/quality-gate.yml. Workflow: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TestKnownModelsasked the image catalog forgpt-image-1. The catalog drops a model fromKnownModels()on its shutdown date, andgpt-image-1retires on 2026-10-23, so from today the test fails on main and takes every open pull request's CI down with it (Lint, Test and Generate Coverage,Floor 2 · Coverage ratchet,Quality Gate).The catalog is right to drop it. The test now asks for the active default
gpt-image-2.5-flare, and says why in a comment.Checked
origin/maincheckout; fails there, passes with this change.KnownModels().go test ./llm/...,./cli/...and./pkg/...pass;golangci-lintv2: 0 issues.