Fix java test: Update expected version from 24 to 25#1572
Draft
Copilot wants to merge 25 commits intocopilot/unify-user-selection-logicfrom
Draft
Fix java test: Update expected version from 24 to 25#1572Copilot wants to merge 25 commits intocopilot/unify-user-selection-logicfrom
Copilot wants to merge 25 commits intocopilot/unify-user-selection-logicfrom
Conversation
…ehensive tests Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
…ection Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
…handling, remove dead code Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
…n refactor Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
The validator expects all directories in src/ to be valid features with devcontainer-feature.json. By renaming to .common (hidden directory), it's excluded from validation while remaining accessible to features. Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
The devcontainer CLI packages each feature independently and doesn't include parent directories or hidden directories in the build context. The helper script must be copied into each feature's _lib/ directory to be accessible at runtime. Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Created scripts/lib/common-setup.sh as the source of truth and scripts/sync-common-setup.sh to deploy to all features. This provides a shared code model within devcontainer packaging constraints. Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
common-utils has different semantics than other features - it CREATES users rather than just using existing ones. Restored the original inline logic that uses _REMOTE_USER without validation since the user will be created. Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
* Initial plan * Fix conda installation by switching from apt repository to direct Miniconda installer Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Add error handling for Miniconda download and installation Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Use APT::Key::GPGVCommand=1 option to bypass SHA1 signature check Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Fix version to 1.2.1 for semantic versioning * Revert to Miniconda installer approach - APT option caused gpgv errors Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Use mktemp for secure temporary file creation Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Replace Miniconda installer with direct .deb package download and apt install Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Fix apt-get install syntax and improve error handling Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Fix package filename - use architecture-specific deb and extract Filename from Packages Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Update version to 1.2.3 Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Fix apt-get install path - remove ./ prefix for absolute paths Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Fix version matching for specific conda versions - handle version suffixes Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
…tu:focal (#1567) * Initial plan * Fix kubectl SHA256 download URL and bump version to 1.3.1 Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Add timeout and fallback for kubectl version fetching Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Improve error messages and diagnostics for kubectl version fetching Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Address code review feedback: clean up error handling Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Improve error message to reference VERSION option Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Use hardcoded fallback version instead of git tags fallback Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Add version validation and comment for fallback version Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Extract fallback version to constant at top of file Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Update fallback version of kubectl to v1.35.1 * Add alternative URL fallback before using hardcoded version Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> Co-authored-by: Abdurrahmaan Iqbal <abdurriq@github.com>
… features (#1569) * Initial plan * Add update-ca-certificates call after installing ca-certificates package Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Bump feature versions: docker-outside-of-docker to 1.8.0, docker-in-docker to 2.16.0 Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Add error handling and documentation for update-ca-certificates calls Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> * Remove invalid test for docker-compose when v2 isn't installed --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com> Co-authored-by: Abdurrahmaan Iqbal <abdurriq@github.com>
…thub-actions-workflow-another-one
Co-authored-by: abdurriq <137001048+abdurriq@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow test-scenarios
Fix java test: Update expected version from 24 to 25
Feb 13, 2026
Base automatically changed from
copilot/fix-github-actions-workflow-another-one
to
copilot/unify-user-selection-logic
February 17, 2026 10:44
abdurriq
force-pushed
the
copilot/unify-user-selection-logic
branch
from
e943772 to
db61bb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
install_latest_versiontest was failing because SDKMAN now provides Java 25.0.2-ms (Microsoft OpenJDK build 25.0.2+10-LTS) as the latest version, but the test still checked for version 24.Changes
test/java/install_latest_version.shfromgrep "24"togrep "25"Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.