Repository navigation
Migrate to quaire 1.0, Vite, and current tooling - #1
Merged
Merged
Conversation
- replace vue cli, webpack, babel and jest with vite 8 and vitest 5 - replace the vue cli pwa plugin with vite-plugin-pwa - update vue, vue-router and all tools to the latest versions - use typescript 6.0 with strict mode and bundler module resolution - use eslint 10 flat config, prettier 3, husky 9 and commitlint - add a github actions workflow for node 22 and 24 - remove cypress and the unused vuex store BREAKING CHANGE: node >= 22.12 is required. The scripts changed: use `npm run dev` instead of `npm run serve` and `npm test` instead of `npm run test:unit`. The e2e tests were removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- replace the MyQuaire subclass with a custom DIALOG component type - convert the story data to the quaire 1.0 format and use variants for the dialog that depends on the "how are you" answer - end the branches with missing next questions and show "THE END" or "TO BE CONTINUED..." when the game is complete - add placeholder dialogs for the brand and age story lines - restore saved games from the result only - show the required error of an input only after a submit - replace lodash.get and lodash.template with a small helper - add tests for the story paths, the components and the game view BREAKING CHANGE: games use the quaire 1.0 question definition (`key`, `title`, `options`, `next`, `variants`) and the dialog property `dialogOptions` is now `lines`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for boring-raman-d3a49a ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Netlify built the site with node 12.18.0, which cannot run husky 9 or vite 8. Set node 22, the build command, the publish directory, and a redirect for the single page app routes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test:release), commitlint.MyQuairesubclass is replaced by a customDIALOGcomponent type. The story data uses the 1.0 format andvariants.nexttargets now end with "THE END" or "TO BE CONTINUED...". The brand and age choices lead to short placeholder dialogs.Breaking changes
npm run devinstead ofserve,npm testinstead oftest:unit.dialogOptionsis nowlines.Notes
8ebc7cedoes not build alone. The code uses the quaire 0.x API untilcbd7a60.activeQuestionIdkey is deleted.Test plan
npm run test:release: typecheck, 25 tests (about 91% line coverage), lint, prettiernpm run buildandvite preview: routes, manifest, and service worker respond🤖 Generated with Claude Code