chore: remove every reference to the absent dsm-gen crate - #886
Merged
Merged
Conversation
`dsm-gen` is not in the tree and not a workspace member, yet QUICKSTART and CONTRIBUTING told contributors to run it (dead commands, a dead README link), deny.toml justified six skips by it, the storage-node Dockerfile stubbed a crate the resolver never asks for, and the Dev SoFi launch screen named it as the source of launch blobs. Docs: the dsm-gen section and the regenerate-through-dsm-gen block are gone. deny.toml: the six prost-0.13 codegen skips stay (tonic-build 0.13 in dsm_sdk still needs them); only their reasons change, so the skip set is unchanged. Dockerfile.cloud: the dsm-gen stub and its synthesized Cargo.toml are deleted; the workspace member list never contained it. DevSoFiLaunch: the copy describes the blob's actual header. cargo-deny is not wired into CI and fails identically on main before and after this change (wildcard-dependency errors unrelated to the skips); the frontend type-check is clean.
cryptskii
added a commit
that referenced
this pull request
Sep 14, 2026
…887) RUSTSEC-2026-0285 (published 2026-09-14, severity 5.3): rustls accepted TLS 1.3 handshake messages across encryption-level boundaries; fixed in 0.23.45. CI's Security audit (Rust gates) fails on it, first seen on #886. Four lockfiles resolve rustls, and all four are live: - Cargo.lock (repo root): the CI audit and workspace build. - dsm_client/deterministic_state_machine/Cargo.lock: that directory is its own workspace root; `make android-libs` and the test board build from it. - crates/dsm-android-anchor/Cargo.lock: the shipped Android cdylib (build.gradle.kts), which links dsm_sdk statically. - crates/dsm-anchor-hw-verifier/Cargo.lock. Each was updated with `cargo update -p rustls@<old> --precise 0.23.45` and each diff is the same four packages: rustls, rustls-webpki 0.103.15, aws-lc-rs 1.18.1, aws-lc-sys 0.45.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dsm-gendoes not exist in the tree (no directory, no workspace member, no Cargo.toml naming it), yet five places referenced it:QUICKSTART.md— a## dsm-gensection with threecargo run -p dsm-gencommands and a deaddsm-gen/README.mdlink: removed.CONTRIBUTING.md— the "read dsm-gen/README.md first" bullet and the "validate and regenerate through dsm-gen" block: removed.deny.toml— six skips justified "retained by dsm-gen and tonic-build": the skips stay (tonic-build 0.13 indsm_sdkstill pulls the prost 0.13 codegen branch); only the reason text changes, so the skip set is byte-for-byte the same set.dsm_storage_node/Dockerfile.cloud— afn main(){}stub and a synthesizeddsm-gen/Cargo.toml"so the resolver doesn't fail": the workspace member list has never containeddsm-gen, so the resolver never asked; removed.DevSoFiLaunchScreen.tsx— copy said the launch blob comes from "dsm-gen compile"; it now describes the blob's actual 3-byte header and points atsofi_routes.rs. Paste-launch stays.Owner ruling 2026-09-14: remove the references; do not restore a crate to satisfy dead links.
Verification
grep -rn "dsm-gen\|dsm_gen"(excludingDSM_GENESISnames) → zero hits.npm run type-check→ 0 errors.cargo deny check bansis not a CI gate (no workflow invokes cargo-deny) and fails identically on the untouchedorigin/maintree and on this branch (same count oferror[wildcard]lines, fromdsm/dsm_sdkwildcard dependencies unrelated to these skips). This change is comment-only indeny.toml.Dockerfile.cloudis used bydsm_storage_node/deploy/push_and_start.sh(owner-run), not by CI (CI buildsci/docker/StorageNode.Dockerfile); the next deploy exercises it. No Rust code changed, somake lintis unaffected.CI note (2026-09-14)
Rust gates → Security audit is red on this PR for a reason unrelated to it. RUSTSEC-2026-0285 (rustls 0.23.42) was published today, and
cargo auditfails onmain's lock too. The fix is #887, which bumps rustls to 0.23.45 in every live lockfile. Once #887 merges, this branch gets a rebase ontomainand the audit step goes green. Every other job on this PR passed or is still running on its own merits.