Repository navigation
fix(ci): the storage layer names only SDK suites that exist - #1070
Merged
Merged
Conversation
A change that touches the storage node and not the SDK runs the `sdk-node-protocol` group, which named four SDK suites that no longer exist: - `b0x_integration` (deleted in #977) and `storage_full_lifecycle` (deleted in #932), integration targets. cargo refuses an unknown target, so the group failed on the first storage-only PR since then (#1069). - `sdk::storage_sync_sdk` and `sdk::storage_node_health`, lib filters. A filter that matches nothing runs nothing and passes, so these narrowed the group's coverage silently. The four names are removed. No SDK integration binary exercises the storage-node contract now, so the group runs one command: the four lib suites that do (`handlers::storage_routes`, `sdk::storage_node_sdk`, `sdk::b0x_sdk`, `sdk::storage_set`). The selector's self-test now refuses a lib filter that does not resolve to a module of dsm_sdk (`test_every_named_sdk_suite_is_a_module_that_exists`). Mutation control: `sdk::storage_sync_sdk` put back, the test is red.
cryptskii
deleted the
fix/ci-selector-names-only-existing-sdk-suites
branch
September 30, 2026 01:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#1069 changes only the storage node, so the layer selector runs the
sdk-node-protocolgroup. That group failed:The group named four SDK suites that no longer exist. #1069 is the first storage-only PR since they were deleted, so nothing had run the group until now.
b0x_integrationstorage_full_lifecyclesdk::storage_sync_sdksdk::storage_node_healthWhat
ci/layers.toml.handlers::storage_routes,sdk::storage_node_sdk,sdk::b0x_sdk,sdk::storage_set). On test(storage): the object store's refusals are exercised #1069 these ran and passed 48 tests; the stale filters added none.ci/select_layers.pyno longer renders an integration-target list.test_every_named_sdk_suite_is_a_module_that_exists, refuses a lib filter that does not resolve to a module ofdsm_sdk. That makes the silent case loud.Evidence
python3 ci/test_select_layers.py: 17 tests, OK.sdk::storage_sync_sdkput back intolib_filtersmakes the new test fail with "sdk::storage_sync_sdk names no module of dsm_sdk". Restored.changed ['STORAGE'] → ['SDK_NODE_PROTOCOL', 'STORAGE'], andsdk-node-protocolruns the single lib command above.Editing
ci/**is a FULL trigger, so this PR runs the full matrix. #1069, rebased after this merges, becomes the first live run of the narrow storage path.Not changed
Which SDK suites a storage change should escalate to is unchanged apart from the dead names. The node-backed SDK lib suites (
handlers::node_e2e_testsand the admission and faucet tests, which stand up real nodes) are not in the group. Adding them is a coverage decision for the owner.