Repository navigation
fix(sdk): the Android-target unit tests compile, and CI compiles them - #1008
Merged
Merged
Conversation
The SDK's tests under #[cfg(target_os = "android")] compile only for an Android target, and nothing built them: they had rotted (21 errors recorded). The last three are fixed — a Base32 test matched a Result where decode returns Option, and a test called a function its module did not import. The Android job now compiles them for arm64 with the library's release profile and features. Nothing runs them on a device yet.
CONFORMANCE_GAPS §6.28: the open item moves to Resolved (#1008); what stays open is that nothing runs them on a device.
cryptskii
added a commit
that referenced
this pull request
Oct 10, 2026
CONFORMANCE_GAPS §6.28: the open item moves to Resolved (#1008); what stays open is that nothing runs them on a device.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placeholder sweep, continued: a recorded open item from CONFORMANCE_GAPS §6.28.
dsm_sdk's tests under#[cfg(target_os = "android")]compile only for an Android target, and nothing built them, so they had rotted (21 errors recorded). Earlier sweep removals took most of those errors with them; this fixes the last three:Resultwherebase32::decodereturnsOption;is_error_envelope_bytes, which its module did not import.The Android Instrumented Tests job now also compiles these tests for arm64, with the library's release profile and features, so they share its dependencies. Nothing runs them on a device yet; that stays recorded open.
Verification:
cargo ndk -t arm64-v8a --platform 23 test --no-run --release --locked --package dsm_sdk --features=jni,bluetooth --libcompiles, as does the debug variant. The workflow YAML parses.