Use padding instead of margin - #357
Closed
jared-hughes wants to merge 2 commits into
Closed
Conversation
To avoid pixel rounding in WebKit.
jared-hughes
force-pushed
the
padding-not-margin
branch
from
August 5, 2026 22:09
71f45b0 to
7acdd5a
Compare
It's still slightly off in Chrome.
Author
|
Closing in favor of #358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Safari, an inline-block parent containing a bunch of inline-block children gets its size over-estimated slightly, likely due to subpixel rounding. E.g. https://jsfiddle.net/Ld09ex1q/.
This PR switches the uses of
marginon digits topadding, since it doesn't have that problem on Safari. It still usesdisplay: inline-blockthough, so the performance on Chrome is still good. This gets us into a good place in all the rendering engines without needing any feature detection.This isn't just a trivial replacement, since
paddingcannot be negative. Requires thetransformapproach.