test: initializes npins lock fixture with npins - #126
Merged
Conversation
vic
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
test-write-lock-npinsfixture to letnpinscreate its own emptylock state instead of hardcoding a
sources.jsonschema version.What changed
pkgs.npinsto the test runtime inputs.with:
Why
The test is intended to verify that
write-lockdetects an existingnpins/sources.jsonand delegates towrite-npins.It should not depend on a hand-written npins lockfile schema version. In one
local environment (mine, lol), the hardcoded
version = 8fixture failed with:Using
npins init --baremakes the fixture compatible with thenpinspackagethat is actually used by the test.
Testing
This branch depends on the Tack compatibility fix for full CI, because
write-lockcurrently realizes all lock backends, including Tack.Validated on the combined integration branch:
Result: passed. Feel free to verify for yourself.
On this branch alone,
test-write-lock-npinsmay still attempt to build old Tackfrom
mainthroughwrite-lock. That issue is fixed byfix/tack-libgit2-compat.Related work
This PR is intentionally test-only and should be reviewed after or alongside
fix/tack-libgit2-compat. The reason I am breaking up my PRs like this is forauditability, but feel free to supersede them if need may be.
The validated integration branch is: