feat: exposes standalone bootstrap writer targets - #125
Open
kalyanoliveira wants to merge 7 commits into
Open
Conversation
Member
|
lgtm, the new broken-app test naturally fails (exit code 1 as intended by its shell app), can you please make sure the CI test is successful ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes each bootstrap writer as a standalone top-level
nix-shell -Atarget.What changed
write-flake,write-npins,write-tack, andbootstrap.flake-file.shas the existing aggregate all-writers shell.commands.
write-flakepath and for isolation from unrelatedapps.
Why
The documented command used the aggregate shell:
That shell realizes every registered backend before running the selected
command. As a result, running
write-flakecould fail because an unrelatedbackend, such as Tack (see my other PR related to this, for instance), failed
to build.
The preferred command is now:
This realizes only the dependencies required for
write-flake.Testing
Result: passed locally. The closure grep did not print Tack. Feel free to test
for yourself.
Note: full
test-allon this branch alone may still be blocked by the old Tackpin from
main. That is fixed by my PRfix/tack-libgit2-compat.Related work
This PR is best reviewed after
fix/tack-libgit2-compat, because that PRunblocks CI failures caused by the old Tack package.
The combined integration branch has also been validated:
On that branch,
nix-shell ./dev/bootstrap-tests.nix --run test-allpasses withthis PR merged together with other related fixes.