fix: updates Tack pin to v1.0.0 - #124
Merged
Merged
Conversation
vic
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the pinned Tack fallback package to Tack
v1.0.0.What changed
8c574901340af860979500f24495417ce7e53cdcwith thev1.0.0releasetarball.
Why
The old Tack revision depends on
git2/libgit2-sys. Itslibgit2-sysversion requires
libgit2 >= 1.9.3, while nixpkgs can sometimes providelibgit2 1.9.2(this was the case with me: I created a thread about this onZullip, but no replies. Hence, PR). Because that old Tack package sets
LIBGIT2_NO_VENDOR, the build fails instead of falling back to vendoredlibgit2.Tack
v1.0.0has moved away fromgit2/libgit2-sysand builds successfullyin this environment.
Testing
Result on this branch:
test-tackpasses.test-write-lock-tackpasses.test-write-lock-npinsbecause of a separatenpins fixture issue fixed in the follow-up PR
test/npins-lock-fixture-version.Targeted Tack smoke test:
Result: passed.
Feel free to verify results for yourself.
Related work
This PR intentionally fixes only the Tack package compatibility issue. The full
set of related changes has also been validated together on the integration
branch:
That integration branch includes this PR plus the standalone writer target,
npins fixture, and bootstrap argument work that I did.