fix(storage): correct the migration number cited for repositories/git_provider_accounts - #7054
Merged
Merged
Conversation
…_provider_accounts Both doc comments said 'migration 199', which drops jira mirror/org columns and has nothing to do with these tables. The tables were actually created in migration 204 (git-provider-accounts-and-repositories.ts).
pedrofrxncx
deleted the
fix/repositories-storage-migration-comment-w2
branch
September 9, 2026 00:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the same doc-drift pattern already fixed in #7053 (a wrong migration number in a schema comment).
Both
apps/api/src/storage/repositories.tsandapps/api/src/storage/git-provider-accounts.tsopen with a doc comment claiming the table was created in "migration 199". Migration 199 (199-drop-jira-mirror-and-org-columns.ts) drops jira mirror/org columns and has nothing to do with either table — bothrepositoriesandgit_provider_accountswere actually created in migration 204 (204-git-provider-accounts-and-repositories.ts), confirmed by reading that migration directly.The payoff: these are brand-new tables (merged this week in #7035) and the wrong citation actively misdirects anyone tracing schema history or debugging a backfill issue back to an unrelated migration.
Verify:
grep -n 'migration 199' apps/api/src/storage/repositories.ts apps/api/src/storage/git-provider-accounts.tsnow returns nothing;cat apps/api/migrations/204-git-provider-accounts-and-repositories.ts | head -5confirms it's the actual origin.Comment-only change, no logic touched. Ran
bun run fmtandbunx oxlinton both files locally; full CI covers the rest.🤖 Generated with Claude Code
Summary by cubic
Corrects the migration number cited in the
repositoriesandgit_provider_accountsschema comments from 199 to 204, so anyone tracing schema history or debugging a backfill no longer lands on the unrelated jira-mirror migration. Comment-only change, no logic touched.Written for commit a5e2d4c. Summary will update on new commits.