refactor(task-board): remove redundant defensive code from useTaskBoardItemPrs - #6985
Open
pedrofrxncx wants to merge 1 commit into
Open
refactor(task-board): remove redundant defensive code from useTaskBoardItemPrs#6985pedrofrxncx wants to merge 1 commit into
pedrofrxncx wants to merge 1 commit into
Conversation
…rdItemPrs The initialData function's cast to 'TaskBoardItemPr[] | undefined' already includes undefined as a valid type, making the trailing '?? undefined' a no-op. Remove it to simplify the code and improve readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the
initialDatafunction inuseTaskBoardItemPrsby removing a redundant no-op fallback. The cast toTaskBoardItemPr[] | undefinedalready includes undefined as a valid type, making the trailing?? undefinedunnecessary.Why: Removes unnecessary defensive code, improving code clarity without changing behavior.
Changes: -2 lines in
apps/web/src/hooks/use-task-board-item-prs.tsVerification:
bun test apps/web/src/lib/task-board-prs-cache.test.ts— 5 passbunx oxlinton both files — 0 warnings, 0 errorsTo verify:
bun test apps/web/src/lib/task-board-prs-cache.test.tsSummary by cubic
Removes the redundant
?? undefinedfallback inuseTaskBoardItemPrs'sinitialDatafunction. The type cast already includesundefined, so the fallback is a no-op and behavior is unchanged.Written for commit ae4ff36. Summary will update on new commits.