fix(create-agent-dropdown): translate the hardcoded "Beta" badge - #6917
Open
pedrofrxncx wants to merge 1 commit into
Open
fix(create-agent-dropdown): translate the hardcoded "Beta" badge#6917pedrofrxncx wants to merge 1 commit into
pedrofrxncx wants to merge 1 commit into
Conversation
The GitHub import beta badge in CreateAgentDropdownContent rendered a literal "Beta" string instead of going through t(), so it never switched to pt-br. Added common.createAgentDropdown.beta to both dictionaries and used t() in the component.
pedrofrxncx
enabled auto-merge (squash)
September 3, 2026 13:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source: bug found auditing
apps/web/src/components/create-agent-dropdown.tsx(my assigned focus area this tick).What:
CreateAgentDropdownContent's GitHub-import beta badge rendered a literalBetastring instead of routing throught(). Per this repo's i18n rule (apps/web/srcmust never hardcode user-facing strings), this silently stayed English even when the app is switched to pt-br, unlike every sibling label in the same dropdown (createFromScratch,importFromGitHub,importFromDeco), which already go throught().Fix: added
common.createAgentDropdown.betato bothen/common.tsandpt-br/common.ts(kept as "Beta" in pt-br too, a standard loanword in pt-br product UI), and swapped the JSX literal fort("common.createAgentDropdown.beta").How to verify:
bunx tsc --noEmitinapps/web(clean for the touched files; the only pre-existing failure is an unrelated prosemirror version-mismatch error inmention-suggestion.tsx), plus a visual check that switching language to pt-br still shows the badge.Checks run locally:
bun run fmt,bunx tsc --noEmit(apps/web),bunx oxlinton the 3 touched files — all clean. Full CI validates the rest.Summary by cubic
Fixes the create agent dropdown's beta badge so it translates to pt-br instead of staying hardcoded as "Beta".
common.createAgentDropdown.betakey to both the English and pt-br dictionaries.BetaJSX string fort("common.createAgentDropdown.beta")increate-agent-dropdown.tsx.Written for commit 4303fd8. Summary will update on new commits.