Skip to content

fix(create-agent-dropdown): translate the hardcoded "Beta" badge - #6917

Open
pedrofrxncx wants to merge 1 commit into
mainfrom
fix/create-agent-dropdown-beta-i18n-w3
Open

fix(create-agent-dropdown): translate the hardcoded "Beta" badge#6917
pedrofrxncx wants to merge 1 commit into
mainfrom
fix/create-agent-dropdown-beta-i18n-w3

Conversation

@pedrofrxncx

@pedrofrxncx pedrofrxncx commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Source: bug found auditing apps/web/src/components/create-agent-dropdown.tsx (my assigned focus area this tick).

What: CreateAgentDropdownContent's GitHub-import beta badge rendered a literal Beta string instead of routing through t(). Per this repo's i18n rule (apps/web/src must never hardcode user-facing strings), this silently stayed English even when the app is switched to pt-br, unlike every sibling label in the same dropdown (createFromScratch, importFromGitHub, importFromDeco), which already go through t().

Fix: added common.createAgentDropdown.beta to both en/common.ts and pt-br/common.ts (kept as "Beta" in pt-br too, a standard loanword in pt-br product UI), and swapped the JSX literal for t("common.createAgentDropdown.beta").

How to verify: bunx tsc --noEmit in apps/web (clean for the touched files; the only pre-existing failure is an unrelated prosemirror version-mismatch error in mention-suggestion.tsx), plus a visual check that switching language to pt-br still shows the badge.

Checks run locally: bun run fmt, bunx tsc --noEmit (apps/web), bunx oxlint on the 3 touched files — all clean. Full CI validates the rest.


Summary by cubic

Fixes the create agent dropdown's beta badge so it translates to pt-br instead of staying hardcoded as "Beta".

  • Adds the common.createAgentDropdown.beta key to both the English and pt-br dictionaries.
  • Swaps the literal Beta JSX string for t("common.createAgentDropdown.beta") in create-agent-dropdown.tsx.

Written for commit 4303fd8. Summary will update on new commits.

Review in cubic

The GitHub import beta badge in CreateAgentDropdownContent rendered a
literal "Beta" string instead of going through t(), so it never
switched to pt-br. Added common.createAgentDropdown.beta to both
dictionaries and used t() in the component.
@pedrofrxncx
pedrofrxncx enabled auto-merge (squash) September 3, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant