Skip to content

fix: ignore Cloudflare __clfb cookie when deciding cache eligibility #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igoramf wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: ignore Cloudflare __clfb cookie when deciding cache eligibility #1100

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b3d49f
fix: ignore Cloudflare __clfb cookie when deciding cache eligibility
igoramf Mar 3, 2026
0f2f131
fix: correct cookie name from __clfb to __cflb
igoramf Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion runtime/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,10 @@ export const middlewareFor = <TAppManifest extends AppManifest = AppManifest>(
}
}

const hasSetCookie = getSetCookies(newHeaders).length > 0;
const setCookies = getSetCookies(newHeaders);
const hasSetCookie = setCookies.some(
(cookie: { name: string }) => cookie.name !== "__clfb",
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Mar 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The ignored cookie name is misspelled (__clfb), so Cloudflare's actual __cflb cookie is not excluded and cache eligibility remains blocked.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At runtime/middleware.ts, line 434:

<comment>The ignored cookie name is misspelled (`__clfb`), so Cloudflare's actual `__cflb` cookie is not excluded and cache eligibility remains blocked.</comment>

<file context>
@@ -429,7 +429,10 @@ export const middlewareFor = <TAppManifest extends AppManifest = AppManifest>(
-      const hasSetCookie = getSetCookies(newHeaders).length > 0;
+      const setCookies = getSetCookies(newHeaders);
+      const hasSetCookie = setCookies.some(
+        (cookie: { name: string }) => cookie.name !== "__clfb",
+      );
       const contentType = newHeaders.get("Content-Type") ?? "";
</file context>
Suggested change
(cookie: { name: string }) => cookie.name !== "__clfb",
(cookie: { name: string }) => cookie.name !== "__cflb",
Fix with Cubic

);
const contentType = newHeaders.get("Content-Type") ?? "";
const isHtmlResponse = contentType.includes("text/html");
// App middleware must explicitly opt in to page caching via the bag
Expand Down
Loading