Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix SoundTouch group Marge compatibility
Summary
This improves the Marge group endpoints used by SoundTouch 10 stereo-pair setup flows.
Rationale
The current group implementation is close, but a real SoundTouch/Stockholm stereo-pair flow expects a few additional response and route shapes:
<group/>, not<groups/>;id;Without these details, the application can complete parts of the pairing flow but fail to persist or retrieve the group state in the shape expected by the original Bose clients.
Implementation Details
GET /marge/streaming/account/{account}/groups.<group/>for ungrouped devices.201 Createdand aLocationheader when creating a group.PUTas well asPOSTfor updating an existing group.DELETE /marge/streaming/account/{account}/group/to clear account groups.Group_<id>.xmlfilename.SoundTouch 10as groupable.Group.idvalue returned bylist_groups().Tests and Validation
soundcork/tests/test_groups.pycovering:<group/>for ungrouped ST10 devices;black --target-version py312 --check soundcork/datastore.py soundcork/groups.py soundcork/groups_service.py soundcork/marge.py soundcork/tests/test_groups.py.isort --check-only soundcork/datastore.py soundcork/groups.py soundcork/groups_service.py soundcork/marge.py soundcork/tests/test_groups.py.git diff --check.pytest -q: 33 passed, with one existing Pydantic deprecation warning.Compatibility and Risk
This is limited to SoundTouch group metadata handling and Marge group endpoint compatibility. It does not change normal playback, account creation, presets, sources, Spotify handling, or miniapp behavior.
The datastore changes are backwards-compatible with existing
Group_<id>.xmlfiles and keep accepting the existing bare-id call style.Non-Goals