Conversation
|
Hi @abhi-roop, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key. |
…ication for Event Hubs sink Signed-off-by: Abhiroop Kumar Singh <abhiroopkumar1234@gmail.com>
514d463 to
ceabdd7
Compare
Naros
left a comment
There was a problem hiding this comment.
Hi @abhi-roop I've left a few inline comments.
One point about the PR description, you mention the use of AZURE_CLIENT_ID, but I don't recall that being documented in the docs PR that accompanies this change. We should probably be sure to include that somehow for users.
Signed-off-by: Abhiroop Kumar Singh <abhiroopkumar1234@gmail.com>
|
Hi @Naros, thanks for the review. I've addressed the feedback:
Also updated the docs PR #8082 to mention |
Naros
left a comment
There was a problem hiding this comment.
Hi @abhi-roop, a few comments below if you could take a look.
Signed-off-by: Abhiroop Kumar Singh <abhiroopkumar1234@gmail.com>
|
Hi @Naros, thanks for the detailed review. Addressed all points:
All seven tests run without Azure credentials. Ready for another look. |
## Summary
Adds support for Azure Entra ID authentication using
DefaultAzureCredential, enabling secretless deployments of the Event Hubs sink on Azure Container Apps, AKS, VMs, and other Azure-hosted environments.Fixes #2647.
New configuration
debezium.sink.eventhubs.authmodeconnection-stringdefault-azure-credentialto use Entra IDdebezium.sink.eventhubs.fullyqualifiednamespaceauthmode=default-azure-credential(e.g.myns.servicebus.windows.net)The existing
connectionstringconfiguration remains supported and is still the default, so there is no breaking change.Notes
authmodeandfullyqualifiednamespaceto follow the existing flat naming convention inEventHubsChangeConsumerConfig(e.g.connectionstring,hubname,partitionid). Happy to switch toauth.mode/fully-qualified-namespaceif preferred.AZURE_CLIENT_IDenvironment variable consumed by Azure Identity.Testing
mvn -pl debezium-server-eventhubs -am clean installpasses locally, including integration tests via Testcontainers.