fix(deps): update dependencies to resolve CVEs and fix export unit test - #1
Merged
Merged
Conversation
Add escape_xml_comment helper that collapses '--' (illegal inside XML comments) after escape_xml; apply it to all three comment-context insertions in generate_dspreset_xml. Extend tests to assert no '--' appears inside any comment body. Move is_recording.store(true) to before thread::spawn in start_recording so the consumer thread never observes false on an empty ring and exits immediately. Add doc comment on max_recording_samples noting interleaved sample counting, and a comment at the self-stop early-return noting un-popped ring samples are intentionally discarded.
CancelRecording now bumps recording_generation so the in-flight worker's RecordingFinished/RecordingError (core returns Ok(partial) on cooperative cancel) become stale and are dropped, instead of wrongly dragging the UI Idle->Review with a partial capture. Also clear info_message in the RecordingError and ExportError arms so a lingering success banner can't sit above a fresh error, and extract the repeated generation guard into is_current_recording(). Adds unit tests for the helper and the cancel->stale-generation invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates workspace dependencies to resolve all cargo audit CVEs and fixes export unit test assertion.