Repository navigation
feat: log effective thread count at startup like dbt 1.x - #16690
Shahzeb-DataEngineer wants to merge 2 commits into
Conversation
Log "Concurrency: N threads (target='X')" once per invocation for runnable commands (run, test, build, seed, snapshot), using the effective thread count after flag/profile/adapter-default resolution. This restores the dbt 1.x startup line so run logs record which value was actually used. Signed-off-by: Shahzeb Ali <126076773+Shahzeb-DataEngineer@users.noreply.github.com>
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @Shahzeb-DataEngineer |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Signed-off-by: Shahzeb Ali <126076773+Shahzeb-DataEngineer@users.noreply.github.com>
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @Shahzeb-DataEngineer |
Description
dbt 1.x printed the thread count at the start of a run (
Concurrency: 4 threads (target='dev')). dbt v2 prints nothing about threads, so there is no way to tell from the logs which value was actually used (profile,--threads, or the adapter default).This PR logs the effective thread count once per invocation, in the same format, for runnable commands (
run,test,build,seed,snapshot):Implementation
set_runtime_max_parallelism(crates/dbt-main/src/compilation.rs) into a pureresolve_effective_threadshelper — no behavior change to the pool cap itself.emit_info_log_message(the standard plain INFO-line helper), scoped to runnable commands via a newis_runnable_commandconst fn (same set asRunTasksArgs::is_runnable), matching dbt 1.x semantics and keeping commands likeparse/list/docsquiet.--threadsflag > profile > adapter default,--threads 0= as many as possible,--no-parallel= 1, adapter default never 0) and for the command scoping.Features) viachangie new.Verification
cargo fmt -p dbt-main -- --checkis clean.compilation.rs(effective_threads_*,concurrency_line_commands_match_runnable_set).cargo testwas not feasible in this environment (cold dependency cache, multi-GB fetch); relying on CI for the full suite.Related Issue
closes #16682