Proto field additions for JiT flow#2182
Open
rafal-hawrylak wants to merge 2 commits into
Open
Conversation
rafal-hawrylak
requested review from
andrzej-grudzien
and removed request for
a team
rafal-hawrylak
force-pushed
the
pr4a-proto-fields
branch
2 times, most recently
from
085649a to
6c8b2c8
Compare
rafal-hawrylak
force-pushed
the
pr4a-proto-fields
branch
from
6c8b2c8 to
121879a
Compare
ikholopov-omni
requested changes
Jun 3, 2026
| // cancelled. Does not bound per-model JiT compilation; see jit_timeout_millis. | ||
| int32 timeout_millis = 7; | ||
|
|
||
| // Per-model JiT compilation worker timeout. Each action with JiT code gets |
Collaborator
There was a problem hiding this comment.
Why do we need it? Why not just use a generic timeout_millis? Scoping JiT stage of execution of timeout_millis looks like a broken contract to me.
| // Current execution information for introspection. | ||
| RunningExecutionData execution_data = 7; | ||
| // File name where the target is defined. | ||
| string file_name = 8; |
Collaborator
There was a problem hiding this comment.
Why do we need it? Is it just for better error handling? (having it in PR description would be helpful)
| string error_message = 2; | ||
| Timing timing = 3; | ||
| ExecutionMetadata metadata = 4; | ||
| string compiled_sql = 5; |
Collaborator
There was a problem hiding this comment.
Why do we need it here? (I have some guess, but please add a comment explaining when it is populated).
|
|
||
| string jit_code = 12; | ||
|
|
||
| bool disabled = 13; |
Collaborator
There was a problem hiding this comment.
Why do we need this now? I don't think it was required before and don't understand why we need it now.
| // Per-model JiT compilation worker timeout. Each model with JiT code gets | ||
| // its own fresh budget; this is per-model, not a shared budget across the | ||
| // compile. | ||
| int32 jit_timeout_millis = 13; |
Collaborator
There was a problem hiding this comment.
Same as protos/execution.proto.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2110 - [Integrate JiT compilation into CLI]