fix: bound multi-image chat payloads#784
Draft
adity982 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Aditya Datta <crazyme07071996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The upload endpoint embedded each original image as base64 in the WebSocket message. A single allowed 10 MiB image expands beyond 13 MiB as base64, so a multi-image message can exceed practical frame limits and lose image context. Bounding only the model-facing preview keeps multi-image payloads manageable without degrading the stored original.
Validation
python -m pytest tests/test_chat_upload_images.py -q— 2 passeduvx ruff check app/services/chat_image_preview.py tests/test_chat_upload_images.pyuvx ruff check --select I app/api/upload.pyAddresses #776.