Allow group workspaces to upload Agent-supported formats#768
Merged
1 commit merged intoJul 23, 2026
Merged
Conversation
Group workspace uploads were limited to UTF-8 JSON writes even though the shared storage and file browser already support binary content. Add authenticated byte upload/download paths while preserving text editing, optimistic version checks, audit records, and safe image previews. Constraint: Preserve existing group text editing and version-token semantics Rejected: Send binary files through the text JSON endpoint | invalid UTF-8 would be rejected or corrupted Confidence: high Scope-risk: moderate Reversibility: clean Directive: Keep Agent and group upload formats sourced from workspaceFileFormats.ts Tested: Backend pytest 1989 passed; frontend 65 tests passed; frontend production build; scoped Ruff Not-tested: Live S3 or Cloudflare upload and browser E2E
Y1fe1Zh0u
added a commit
that referenced
this pull request
Jul 22, 2026
The integration branch needs this pull request alongside the other v1.11.2 candidates without changing the original PR state. Constraint: Preserve the source PR commit and merge in numeric order. Confidence: high Scope-risk: moderate Related: #768 Tested: Git merge completed without unresolved conflicts Not-tested: Combined backend and frontend suites pending
Y1fe1Zh0u
closed this pull request by merging all changes
into
dataelement:main
in
40c1f6b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The group workspace frontend only accepted a small UTF-8 text allowlist, and its backend write contract accepted JSON strings rather than raw file bytes. The underlying storage layer and Agent workspace already supported binary content, but the group boundary did not expose equivalent upload or download paths.
User impact
Group members can now upload the same common documents and images offered by the Agent workspace: PDF, DOCX, XLSX, PPTX, PNG, JPEG, GIF, SVG, and WebP, alongside the existing text and code formats. Images can be previewed; office documents and other binary files can be downloaded without text transcoding.
No database migration or new dependency is required.
Validation
1989 passed21 passed65 passednpm run buildgit diff --check: passedNot tested