Added fix for an error when table name was having hyphens and source transfers were failing. - #1618
Merged
Conversation
vikasrathee-cs
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the table name generation in PartitionedBigQueryInputFormat.java to wrap the table identifier in backticks, preventing issues with special characters like hyphens. The reviewer noted that this change will break existing unit tests in PartitionedBigQueryInputFormatTest.java and requested updating them. Additionally, a minor formatting issue with an extra space in the String.format arguments was identified and a code suggestion was provided to fix it.
vikasrathee-cs
force-pushed
the
hyphen-fix
branch
from
July 27, 2026 14:39
b54d320 to
63096a8
Compare
sahusanket
approved these changes
Jul 29, 2026
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fix for an error when table name was having hyphens and source transfers were failing.