feat(page-element): allow a fixed aspect ratio for visualizations#93
Draft
BatLeDev wants to merge 1 commit into
Draft
feat(page-element): allow a fixed aspect ratio for visualizations#93BatLeDev wants to merge 1 commit into
BatLeDev wants to merge 1 commit into
Conversation
d-frame only derives its height from its own measured width, so it cannot cap itself to a max height without cropping. The wrapping container now caps the width instead (maxHeight × ratio), shrinking the visualization horizontally rather than cropping it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ratiofield (free text with 16/9, 4/3, 1/1, 3/2, 21/9 suggestions, defaultauto) to keep the current responsive ratio or fix it to a constant value.maxHeightfield, shown only when a fixed ratio is set.maxHeight × ratio), shrinking it horizontally rather than cropping it.