fix(portal): small UI and a11y fixes (nav logo, metrics, contact, reuse card)#91
Merged
Conversation
The v-container already adds px-4 when fluid is false, so the logo's own pl-4 produced a double left padding. Keep pl-4 only in full-width mode where the container has no padding.
Match the v1 kpi component: bold uppercase title, value and label sized like v1, and add horizontal padding so the cards no longer hug their content.
A tel: link does not open a new window, so drop target=_blank and the misleading 'new window' title, and add an explicit aria-label. Render the phone label in the list item default slot so it wraps instead of being truncated by Vuetify's v-list-item-title.
The reuse card footer used a bare v-list-item while dataset and application cards use a no-gutters px-4 py-2 row. Use the same row so the author/date block is spaced consistently.
BatLeDev
force-pushed
the
fix-portal-ui-small-fixes
branch
from
bcc6704 to
bc7078f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quelques petits correctifs visuels et d'accessibilité sur le portail :
pl-4n'est gardé qu'en pleine largeur, où le container n'a pas de padding).tel:n'ouvre pas de nouvel onglet → suppression detarget="_blank"et dutitle« Nouvelle fenêtre » trompeur, ajout d'unaria-labelexplicite, et libellé déplacé dans le slot duv-list-itempour qu'il revienne à la ligne au lieu d'être tronqué.v-row no-gutters px-4 py-2des cartes jeux de données/visualisations.Heads-up : le
px-12des chiffres clés et la taille de la valeur sont à valider visuellement (notamment sur mobile) contre le portail v1 de référence.