Skip to content

TestErrorLogger: added tests #8413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Apr 7, 2026
+43 −0
Merged

TestErrorLogger: added tests #8413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dceadd2
TestErrorLogger: added tests for symbol and newline in error messages
firewave Jan 12, 2025
f9a7db2
TestErrorLogger: added test for `{code}`
firewave Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions test/testerrorlogger.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ class TestErrorLogger : public TestFixture {
TEST_CASE(ErrorMessageConstructLocations);
TEST_CASE(ErrorMessageVerbose);
TEST_CASE(ErrorMessageVerboseLocations);
TEST_CASE(ErrorMessageVerboseSymbol);
TEST_CASE(ErrorMessageVerboseNewline);
TEST_CASE(ErrorMessageFromInternalError);
TEST_CASE(ErrorMessageCode);
TEST_CASE(CustomFormat);
TEST_CASE(CustomFormat2);
TEST_CASE(CustomFormatLocations);
Expand Down Expand Up @@ -284,6 +287,27 @@ class TestErrorLogger : public TestFixture {
ASSERT_EQUALS("[foo.cpp:5] -> [bar.cpp:8]: (error) Verbose error", msg.toString(true, templateFormat, ""));
}

void ErrorMessageVerboseSymbol() const {
std::list<ErrorMessage::FileLocation> locs(1, fooCpp5);
ErrorMessage msg(std::move(locs), "", Severity::error, "$symbol:sym\nProgramming error with $symbol.\nVerbose error about $symbol", "errorId", Certainty::normal);
ASSERT_EQUALS(1, msg.callStack.size());
ASSERT_EQUALS("Programming error with sym.", msg.shortMessage());
ASSERT_EQUALS("Verbose error about sym", msg.verboseMessage());
ASSERT_EQUALS("[foo.cpp:5]: (error) Programming error with sym.", msg.toString(false, templateFormat, ""));
ASSERT_EQUALS("[foo.cpp:5]: (error) Verbose error about sym", msg.toString(true, templateFormat, ""));
ASSERT_EQUALS("sym\n", msg.symbolNames());
}

void ErrorMessageVerboseNewline() const {
std::list<ErrorMessage::FileLocation> locs(1, fooCpp5);
ErrorMessage msg(std::move(locs), "", Severity::error, "Programming error.\nVerbose error\nEven more verbose", "errorId", Certainty::normal);
ASSERT_EQUALS(1, msg.callStack.size());
ASSERT_EQUALS("Programming error.", msg.shortMessage());
ASSERT_EQUALS("Verbose error\nEven more verbose", msg.verboseMessage());
ASSERT_EQUALS("[foo.cpp:5]: (error) Programming error.", msg.toString(false, templateFormat, ""));
ASSERT_EQUALS("[foo.cpp:5]: (error) Verbose error\nEven more verbose", msg.toString(true, templateFormat, ""));
}

void ErrorMessageFromInternalError() const {
// TODO: test with token
{
Expand Down Expand Up @@ -341,6 +365,25 @@ class TestErrorLogger : public TestFixture {
testReportType(ReportType::certC, Severity::error, "resourceLeak", "L3", "FIO42-C");
}

void ErrorMessageCode() const {
ScopedFile file("code.cpp",
"int i;\n"
"int i2;\n"
"int i3;\n"
);

ErrorMessage::FileLocation codeCpp3_5{"code.cpp", 3, 5};
std::list<ErrorMessage::FileLocation> locs = { codeCpp3_5 };
ErrorMessage msg(std::move(locs), "", Severity::error, "Programming error.\nVerbose error", "errorId", Certainty::normal);
ASSERT_EQUALS(1, msg.callStack.size());
ASSERT_EQUALS("Programming error.", msg.shortMessage());
ASSERT_EQUALS("Verbose error", msg.verboseMessage());
ASSERT_EQUALS("code.cpp:3:5: error: Programming error. [errorId]\n"
"int i3;\n"
" ^",
msg.toString(false, "{file}:{line}:{column}: {severity}:{inconclusive:inconclusive:} {message} [{id}]\n{code}", ""));
}

void CustomFormat() const {
std::list<ErrorMessage::FileLocation> locs(1, fooCpp5);
ErrorMessage msg(std::move(locs), "", Severity::error, "Programming error.\nVerbose error", "errorId", Certainty::normal);
Expand Down
Loading