Repository navigation
fix(sourcehut): parse web urls on instance root host - #266
Conversation
Bare https://sr.ht/~foo/bar is a valid alias for https://git.sr.ht/~foo/bar.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
| Layer / File(s) | Summary |
|---|---|
Instance-root parsing and coverage src/sourcehut/web.ts, test/unit/sourcehut.test.ts, docs/content/4.providers/sourcehut.md |
The host list includes the instance root. Tests cover repository parsing, profile URL handling, and Git host URL generation. The documentation describes these behaviours. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- danielroe/forges#259: Changes Sourcehut instance derivation and passes the instance into
sourcehutWeb.
Suggested reviewers: danielroe
Merge Risk: 
Minimal · previous review 7d36d
-
The SourceHut URL alias behavior is implemented and documented consistently, with no actionable merge-blocking risk identified.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
commit: |
Architecture Data flow Tip Open a diagram on the canvas, then press W or click play to walk through the change one step at a time 🪧 More tips
Thanks for using PR Lens! It's free for OSS. If it helped, a star helps other teams find it. |
Bundle sizeBrowser entry bundles compared with the PR base. All sizes are in bytes. Lazy totals the minified chunks besides the entry, which load on demand or never.
Size changes are informational. Measured for |
🔗 Linked issue
N/A
🧭 Context
Bare https://sr.ht/~foo/bar is a valid alias for https://git.sr.ht/~foo/bar, but we weren't handling it.
Caught while integrating
forgesinto npmx.🧪 Testing
Added unit tests
📚 Docs
Added a note about it