Feature/tala default layout 5021638596232649331 - #165
Open
KhaledQasim wants to merge 4 commits into
Open
KhaledQasim wants to merge 4 commits into
KhaledQasim wants to merge 4 commits into
Conversation
Added a `semver` check against the installed D2 executable to determine if TALA is natively available (`>= 0.6.0`), and fallback to checking for `d2plugin-tala` on the user's PATH if they are using an older version. Updated `package.json` to reflect that TALA is no longer strictly "available if installed". Co-authored-by: KhaledQasim <98847296+KhaledQasim@users.noreply.github.com>
Added a `semver` check against the installed D2 executable to determine if TALA is natively available (`>= 0.6.0`), and fallback to checking for `d2plugin-tala` on the user's PATH if they are using an older version. Updated `package.json` to reflect that TALA is no longer strictly "available if installed". Co-authored-by: KhaledQasim <98847296+KhaledQasim@users.noreply.github.com>
The global `path { fill: ... }` rule in previewPage.html, added to color the toolbar's zoom/refresh icons, also overrode the fill on the injected D2 diagram's own paths. Since a CSS rule beats an SVG presentation attribute, every edge (fill="none", no fill class) got painted solid instead of staying stroke-only, corrupting the preview or any diagram with connectors.
Author
|
added fix for the commit added in March 2024 (commit 7da4ca1/c9d3162, "Add a recompile button") to color the toolbar's zoom/refresh SVG icons — but it's unscoped, so it applies to every "path" in the whole document, including the D2 diagram itself once it's injected into #previewWrapper bug has sat in the codebase since March 2024, after the last marketplace release (Sept 2023) , so it was never actually shipped. That is how i discovered it now and also fixed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds conditional logic to include
talaas an available layout option if the user hasd2version0.6.0or greater, which comes with TALA bundled. It falls back to checking ford2plugin-talafor backwards compatibility.