Skip to content

fix(sqlite): support dropping columns on legacy runtimes - #504

Merged
JimmyDaddy merged 2 commits into
masterfrom
fix/sqlite-legacy-drop-column
Aug 18, 2026
Merged

JimmyDaddy merged 2 commits into
masterfrom
fix/sqlite-legacy-drop-column

Conversation

@yicai-dev

@yicai-dev yicai-dev commented Aug 17, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #396.

Summary

  • detect whether the active SQLite runtime supports DROP COLUMN
  • rebuild the table for SQLite versions before 3.35.0
  • preserve the native DROP COLUMN path on modern SQLite
  • cover the legacy path with a data-preservation regression test

Leoric accepts sqlite3 ^5.0.2, whose bundled SQLite 3.34.0 predates DROP COLUMN support.

Verification

  • TypeScript build and declaration generation
  • ESLint on changed files
  • focused DROP COLUMN capability and legacy rebuild regressions
  • complete SQLite integration suite: 289 passing, 1 pending

@yicai-dev
yicai-dev requested a review from JimmyDaddy August 17, 2026 09:44
@codecov

codecov Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.59%. Comparing base (fcc053a) to head (2adc2cc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #504   +/-   ##
=======================================
  Coverage   97.58%   97.59%           
=======================================
  Files          47       47           
  Lines        4272     4283   +11     
  Branches     1033     1038    +5     
=======================================
+ Hits         4169     4180   +11     
  Misses         14       14           
  Partials       89       89           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JimmyDaddy
JimmyDaddy merged commit b975113 into master Aug 18, 2026
6 checks passed
@JimmyDaddy
JimmyDaddy deleted the fix/sqlite-legacy-drop-column branch August 18, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]model字段变更后,sync方法没有成功删除该字段

3 participants