Fix/macos detach event listeners - #338
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and bug fixes to the Twilio Voice Flutter plugin, particularly for macOS support and JavaScript interop. The most significant changes include expanded platform support for incoming calls, improved handling of custom parameters in JS interop, more robust event listener management, and some code cleanup for call disposal.
Platform support improvements:
_AppState(main.dart). [1] [2]JavaScript interop and event listener management:
customParametersmethod inTVCall.swiftnow correctly handles Twilio's JS Map by converting it to a plain object, ensuring parameters are accessible on macOS. Also, custom parameters only fill gaps not covered by Twilio's authoritative parameters. [1] [2]removeListenerinstead ofofffor better compatibility. [1] [2] [3]Twilio event support:
detachEventListenerswas expanded to includewarningandwarningClearedevents.Code cleanup:
twilioCall?.dispose()were removed fromTwilioVoicePlugin.swiftto prevent unnecessary disposal. [1] [2] [3]