Better integration of music21j MIDI with m21p in Jupyter#1892
Merged
Conversation
mscuthbert
changed the title
|
coverage: 93.071% (+0.002%) from 93.069% — midi-try-two into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update music21's Jupyter MIDI output to properly load a particular pinned version of music21j (including CSS and soundfonts). Hopefully this will be the last time that MIDI breaks when music21j is updated, and the version of m21j on Github can be properly kept up to date w/o breaking m21p!