Conversation
tkhquang
force-pushed
the
fix/trap-transaction-status
branch
from
July 16, 2026 00:04
597432e to
45b1060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trap_threadsreturn protection/query failures to inline-hook callersRationale
The Windows trap manager currently retains each target page for the process lifetime. If that virtual address is later recycled, an unrelated execute fault on the page is resumed without changing context and repeats indefinitely. The protection transaction also ignores query/protection failures, allowing enable or disable to report success when no patch was applied.
The patch keeps the same-page retry behavior only while a transaction has deliberately removed execute permission, then removes the trap record before returning on every path.
Validation
The native SafetyHook suites pass with MinGW and MSVC. The downstream DetourModKit regression suite also covers recycled-address trap cleanup and failed enable/disable state under MinGW Debug/Release, MSVC Debug/Release, and MSVC ASan.