Repository navigation
append: diagnose a missing equals sign before checking the component - #454
Open
rajmodi8905 wants to merge 1 commit into
Open
rajmodi8905 wants to merge 1 commit into
rajmodi8905 wants to merge 1 commit into
Conversation
Author
|
Hi maintainers, gently following up on this diagnostic fix for #414. Could someone take a look when you have a moment? Happy to make any changes needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--append querycurrently reports thatqueryis unsupported. Check the argument syntax first and report the missing=. Correctly formed unsupported components keep their existing diagnostic and exit code.Fixes #414.
Add regression tests for bare
query,path, andhost, plus ahost=example.comcontrol. The three missing-equals tests fail before the change.Validation:
make trurl,make checksrc, and the full suite pass (202 passed, 15 feature skips). The same suite passes with AddressSanitizer and UndefinedBehaviorSanitizer. Valgrind was unavailable locally, somake test-memorycould not run; ASan leak detection was disabled on macOS.