Skip to content

Install Python deps via apt so the root service can import them (#74) #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuneytozseker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Install Python deps via apt so the root service can import them (#74) #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,15 @@ If you prefer to install step-by-step:

```bash
sudo apt update && sudo apt install -y \
python3-pip python3-pygame python3-pil \
python3-pip python3-pygame python3-pil python3-numpy \
python3-flask python3-requests python3-dotenv \
git libsdl2-dev libsdl2-image-dev libsdl2-ttf-dev

pip3 install requests flask python-dotenv --break-system-packages
```

Install these with `apt` rather than `pip3 --user`. The systemd service runs as
root, and packages installed into your own `~/.local` are not on root's import
path — the service would fail to start with `No module named flask`.

#### 2. Clone the repo

```bash
Expand Down
18 changes: 13 additions & 5 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,25 @@ if systemctl is-active --quiet lightdm 2>/dev/null || systemctl is-active --quie
fi

# 3. Install system deps
# Everything comes from apt so it lands system-wide. The systemd service runs as
# root, and a user-level pip install would be invisible to it (see issue #74).
echo -e "${B}[2/7]${N} Installing system dependencies..."
sudo apt update -qq
sudo apt install -y -qq \
python3-pip python3-pygame python3-pil \
python3-pip python3-pygame python3-pil python3-numpy \
python3-flask python3-requests python3-dotenv \
git libsdl2-dev libsdl2-image-dev libsdl2-ttf-dev \
> /dev/null

# 4. Install Python deps
echo -e "${B}[3/7]${N} Installing Python packages..."
pip3 install --quiet --break-system-packages requests flask python-dotenv 2>/dev/null || \
pip3 install --quiet requests flask python-dotenv
# 4. Verify the service user can import everything
echo -e "${B}[3/7]${N} Verifying Python packages..."
DEP_CHECK='import pygame, PIL, numpy, flask, requests, dotenv'
if ! sudo python3 -c "$DEP_CHECK" > /dev/null 2>&1; then
echo -e "${R}Dependency check failed as root.${N}"
echo "The service runs as root and will not start. Details:"
sudo python3 -c "$DEP_CHECK" 2>&1 | tail -1
exit 1
fi

# 5. Clone or update repo
echo -e "${B}[4/7]${N} Fetching TinyProgrammer ${TAG}..."
Expand Down