Skip to content

test: add synthetic model mode checks - #23

Merged
phiscu merged 1 commit into
masterfrom
test-model-edge-cases-1.0.2
Aug 3, 2026
Merged

test: add synthetic model mode checks#23
phiscu merged 1 commit into
masterfrom
test-model-edge-cases-1.0.2

Conversation

@phiscu

@phiscu phiscu commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@phiscu

phiscu commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator Author

Summary

This pull request expands the test coverage for MATILDA 1.0.2 before maintenance work begins.

It adds deterministic synthetic tests for:

  • parameter initialization and validation;
  • rain–snow separation and precipitation conservation;
  • snow and ice melt, refreezing, and glacier-reservoir bookkeeping;
  • simulations without glaciers;
  • simulations with a fixed glacier area;
  • leap-year handling, repeatability, and input-data preservation;
  • one complete model evaluation through mspot.

Exact reference outputs are included for the zero-glacier and fixed-glacier configurations. These
references will make it possible to identify and quantify numerical changes caused by future
modifications to the core routines.

Scope

This pull request changes only tests, test documentation, and test configuration. It does not modify
the model implementation or its scientific behaviour.

The runoff data used for the mspot test are synthetic. They test data alignment, unit conversion, and
objective-function calculation, but they do not assess model performance or scientific validity.

Validation

  • Full test suite: 22 passed
  • Dependency consistency check: passed
  • Wheel build and installed-wheel verification: passed
  • Existing and new numerical reference comparisons: no changes detected

Remaining test gaps

Further tests are still needed for:

  • complete glacier loss;
  • positive cumulative glacier mass balance;
  • serial-versus-parallel calibration equivalence.

@phiscu
phiscu merged commit ae513e7 into master Aug 3, 2026
1 check passed
@phiscu
phiscu deleted the test-model-edge-cases-1.0.2 branch August 3, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant