Skip to content

cli: default exec cwd to container workspace folder #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bilby91 merged 1 commit into from
May 22, 2026
Merged

cli: default exec cwd to container workspace folder #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cmd/devcontainer/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,23 @@ func newExecCmd(rf *rootFlags) *cobra.Command {
}
defer restore()

// Default cwd to the resolved container workspace folder
// when --working-dir wasn't given, so `devcontainer exec ls`
// lands inside the project rather than wherever the base
// image's WORKDIR points.
wd := workingDir
if wd == "" {
wd = cfg.ContainerWorkspaceFolder
}

// NOTE: window-size forwarding (SIGWINCH → resize) is not
// wired here yet — the runtime ExecOptions surface for it
// is still in-flight on main. Once it lands we can plumb
// term.GetSize + signal.Notify(SIGWINCH) through.
res, err := eng.Exec(ctx, workspace, devcontainer.ExecOptions{
Cmd: args,
User: user,
WorkingDir: workingDir,
WorkingDir: wd,
Tty: tty,
Stdin: os.Stdin,
Stdout: os.Stdout,
Expand Down
Loading