Add paths from CMAKE_PREFIX_PATH env var to CMAKE_FIND_ROOT_PATH#1756
Open
toivosnare wants to merge 1 commit intocross-rs:mainfrom
Open
Add paths from CMAKE_PREFIX_PATH env var to CMAKE_FIND_ROOT_PATH#1756toivosnare wants to merge 1 commit intocross-rs:mainfrom
CMAKE_PREFIX_PATH env var to CMAKE_FIND_ROOT_PATH#1756toivosnare wants to merge 1 commit intocross-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cmake-rs crate passes the install paths of dependencies via the
CMAKE_PREFIX_PATHenvironment variable instead of the the normalCMAKE_PREFIX_PATHcache variable: https://github.com/rust-lang/cmake-rs/blob/511160ffce8d27632d20770b7090b9f73dda26c6/src/lib.rs#L828. Thus, in addition to the paths from the cache variable, also paths from the environment variable should be added to theCMAKE_FIND_ROOT_PATHto make them discoverable during cross compilation.