Detect platforms in packages without a name - #151
Merged
Merged
Conversation
|
👋 @marcospassos
☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm manifest schema required
name, so apackage.jsonwithout one (common in private apps) failed validation andreadManifestreturnednull. Every dependency check then reportedfalse, and detection fell through to theJAVASCRIPTcandidate, whose predicate only checks thatpackage.jsonexists.A Nuxt app was reported as a plain JS project. The same applied to Next.js, React, Vue and Hydrogen, as well as to
getScriptsand server command detection.nameis now optional, matching the Composer manifest schema, andgetDependencyfalls back to the requested name.