Support running bwc upgrade tests with versions temporarily set to tarball/branch#409
Merged
mfussenegger merged 2 commits intomasterfrom Apr 14, 2026
Merged
Support running bwc upgrade tests with versions temporarily set to tarball/branch#409mfussenegger merged 2 commits intomasterfrom
mfussenegger merged 2 commits intomasterfrom
Conversation
…rball/branch
Changes the `create table versioned.t{version}` statement to `create
table versioned.t{idx}`
This avoids table name validation errors if setting the `VersionDef`
version to a tarball path to validate a fix.
mfussenegger
commented
Apr 14, 2026
| yield versions | ||
|
|
||
|
|
||
| def path_repr(path: VersionDef) -> str: |
mfussenegger
commented
Apr 14, 2026
| self.assert_data_persistence(idx, version_def, nodes, digest, paths, accumulated_dynamic_column_names) | ||
|
|
||
| # restart with latest version | ||
| version_def = versions[-1] |
Member
Author
There was a problem hiding this comment.
In python the loop variables remain in scope with the values from the last iteration.
BaurzhanSakhariev
approved these changes
Apr 14, 2026
Contributor
|
Tests are failing because they were run before the revert of an offending commit? |
Member
Author
|
retest this please |
Member
Author
It's due to |
Member
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
create table versioned.t{version}statement tocreate table versioned.t{idx}This avoids table name validation errors if setting the
VersionDefversion to a tarball path to validate a fix.