Repository navigation
[6.x] Show workflow stage type icons in the picker - #20660
Merged
Merged
Conversation
Keep Iconic optional for workflow stages and give User Review its user-magnifying-glass icon. Amp-Thread-ID: https://ampcode.com/threads/T-01a1d3f3-a29b-7489-ace2-82616452f915 Co-authored-by: Amp <amp@ampcode.com>
Reference #20660 in the Craft 6 release notes. [ci skip] Amp-Thread-ID: https://ampcode.com/threads/T-01a1d3f3-a29b-7489-ace2-82616452f915 Co-authored-by: Amp <amp@ampcode.com>
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The base stage class and interface are unchanged, so plugin stage types do not need to implement
Iconic.Evidence
iconwas missing from the stage type payload. The picker regression expecteduser-magnifying-glassbut receivedplus.After: all 59 workflow PHP tests and 39 workflow frontend tests pass, including the icon and fallback checks.
composer cipasses: Pint, Rector, PHPStan, 12,623 core tests passed with 25 skipped, and 1,018 adapter tests passed with 9 skipped. TypeScript, frontend lint/format checks, and the production build also pass.Before, from the reported screenshot:
After, light and dark themes: