Repository navigation
[6.x] Serve front-end requests from the read replica - #20640
Merged
Merged
Conversation
Craft's runtime column checks went through Laravel's schema builder, which always introspects the write connection, and Cms::isInstalled() opened the write PDO, so every request queried the primary and failed when it was down. - Add a getReadSchemaBuilder() connection macro and use it for runtime column checks - Check the read connection in Cms::isInstalled() - Fix ConnectionConfig::dsn() for read/write configs that list hosts Amp-Thread-ID: https://ampcode.com/threads/T-01a1d073-c4bf-74bd-9848-8353ad4c0f73 Co-authored-by: Amp <amp@ampcode.com>
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
Windows can't delete a file that an open PDO still holds. Amp-Thread-ID: https://ampcode.com/threads/T-01a1d073-c4bf-74bd-9848-8353ad4c0f73 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Laravel's read/write connections mostly work in Craft already, but three things still went to the write connection (the primary). Front-end requests kept querying the primary, and a site couldn't serve pages from its replica while the primary was down.
getReadSchemaBuilder()introspects the read connection through Laravel's{name}::readconnection. If the connection would read from the write connection anyway (in the console, inside a transaction, or after a write whenstickyis on), it uses the normal schema builder instead. That way, a request that has just migrated never reads stale schema from a lagging replica.Evidence
I tested a workbench in an orb with streaming replication on PostgreSQL 15 and on MySQL 8.4 (GTID,
super_read_onlyreplica). I counted the statements each server logged for every request.isInstalled()), then 500 (schema checks){% cache %}, users, relations, existing transforms; primary downNew regression tests (each fails on the old code):
Known limits that still need the primary:
imagetransformindexrow).Craft::$app->db).