[riasvdv]

Description

Saving a plugin's settings no longer writes config/craft/<handle>.php overrides into project config. Settings the config file overrides keep their stored project config value, or stay absent if they had none. Everything else saves as before.

 Plugins::savePluginSettings($plugin, $posted)
   $settings->setAttributes($posted)   # live model still has file overrides merged in
   validate → SavingPluginSettings → beforeSaveSettings()
-  projectConfig.set(plugins.<handle>.settings, validationData())
+  projectConfig.set(plugins.<handle>.settings,
+    validationData() minus keys in config("craft.<handle>")
+    + stored values for those keys)
   afterSaveSettings() → PluginSettingsSaved   # unchanged; they read the live model

In 5.x, overridden fields were rendered disabled, so they weren't posted, and only posted keys were saved. In 6.x, read-only fields are posted, and the whole validationData() was saved. That included the file's values, replacing the CP values. After the config file was removed, the CP values were gone.

The live settings model still holds the file's values after saving, so afterSaveSettings() and PluginSettingsSaved listeners see the same runtime settings as before. Only the stored project config changes.

Evidence

config/craft/test-plugin.php: ['bar' => 'File bar']
project config:               ['foo' => 'CP foo', 'bar' => 'CP bar']
savePluginSettings(['foo' => 'Submitted', 'bar' => 'File bar'])

• Before: project config → ['bar' => 'File bar', 'foo' => 'Submitted']. On 6.x, 5 tests in tests/Feature/Plugin/ fail.
  After: project config → ['bar' => 'CP bar', 'foo' => 'Submitted']. With no stored bar, it stays absent: ['foo' => 'Submitted']. tests/Feature/Plugin/: 103 passed. composer ci passes.

Three existing tests asserted that file values were saved to project config. They now assert that file values are left out. The PluginConfigurationTest one also checks the rows flushed to the projectconfig table: the stored bar row stays "Stored bar" after flushing.

Related issues

• Found while QA-ing [4.x] Make Contact Form fully Laravel-native for Craft 6 contact-form#275

[github-actions]

📚 Storybook previews

@craftcms/ui — open Storybook

No changed components detected in this Storybook.

resources/js — open Storybook

No changed components detected in this Storybook.